Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide register template, create/upload volume and create vpc buttons when zone is not created. #10243

Open
wants to merge 1 commit into
base: 4.19
Choose a base branch
from

Conversation

abh1sar
Copy link
Collaborator

@abh1sar abh1sar commented Jan 22, 2025

Description

This PR fixes #8145

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@abh1sar
Copy link
Collaborator Author

abh1sar commented Jan 22, 2025

@blueorangutan ui

@blueorangutan
Copy link

@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.14%. Comparing base (d053bb9) to head (09994a4).
Report is 9 commits behind head on 4.19.

Additional details and impacted files
@@            Coverage Diff             @@
##               4.19   #10243    +/-   ##
==========================================
  Coverage     15.13%   15.14%            
- Complexity    11279    11281     +2     
==========================================
  Files          5408     5408            
  Lines        474007   473783   -224     
  Branches      57822    57812    -10     
==========================================
+ Hits          71746    71752     +6     
+ Misses       394240   394009   -231     
- Partials       8021     8022     +1     
Flag Coverage Δ
uitests 4.29% <ø> (-0.01%) ⬇️
unittests 15.86% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abh1sar
Copy link
Collaborator Author

abh1sar commented Jan 22, 2025

@blueorangutan package

@blueorangutan
Copy link

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12178

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 23, 2025

@abh1sar , I think the solution should not be UI only. The API as well should fail at service level, agree?

Edit: not that this would not be an improvement.

@DaanHoogland DaanHoogland added this to the 4.19.2 milestone Jan 23, 2025
@abh1sar
Copy link
Collaborator Author

abh1sar commented Jan 24, 2025

@abh1sar , I think the solution should not be UI only. The API as well should fail at service level, agree?

Edit: not that this would not be an improvement.

@DaanHoogland the 'zone' parameter is required for the api, so the api returns an error if zone is not specified.

@DaanHoogland DaanHoogland changed the title Hide register template, create/upload volume and create vpc buttons wheen zone is not created. Hide register template, create/upload volume and create vpc buttons when zone is not created. Jan 24, 2025
@DaanHoogland
Copy link
Contributor

@DaanHoogland the 'zone' parameter is required for the api, so the api returns an error if zone is not specified.

yes, you are right. 👍

Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10243 (QA-JID-532)

@borisstoyanov borisstoyanov self-assigned this Jan 27, 2025
Copy link
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also add:
Images:

  • ISOs - register/upload iso
  • Kubernetes - Add kub version
    Network:
  • VNF Appliance - add VNF appliance
  • s2s VPN - Add VPN GW
  • VPN Users - Add User
  • VPN Cust Gateway - Add
    Storage:
  • Buckets - create
    Compute
  • Add instance
  • Kubernetes - create kub cluster
  • autoscale IG - New autoscale IG
  • Instance group - new IG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

As a user I can start registring templates before a zone is created
4 participants